Skip to content

[dwds] Cleanup unused null safety related fields #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2025
Merged

[dwds] Cleanup unused null safety related fields #2660

merged 5 commits into from
Aug 13, 2025

Conversation

nshahan
Copy link
Contributor

@nshahan nshahan commented Jul 31, 2025

No description provided.

@nshahan nshahan force-pushed the dwds-null-safety-cleanup branch from c72b594 to de79811 Compare August 1, 2025 17:17
@nshahan
Copy link
Contributor Author

nshahan commented Aug 1, 2025

@jyameo @bkonyi It seems like when the public APIs were deprecated we wanted to wait until the next major version to remove them. Do we have any other plans for a major version bump soon? I can wait to land this if we need to release another minor version first.

@nshahan nshahan requested review from bkonyi and jyameo August 1, 2025 18:48
@bkonyi
Copy link
Collaborator

bkonyi commented Aug 5, 2025

I see no reason why we couldn't do a major version bump. Can you also remove the deprecated parameter in dwds/lib/dart_web_debug_service.dart as well?

@nshahan
Copy link
Contributor Author

nshahan commented Aug 5, 2025

I see no reason why we couldn't do a major version bump. Can you also remove the deprecated parameter in dwds/lib/dart_web_debug_service.dart as well?

Done!

@nshahan nshahan mentioned this pull request Aug 12, 2025
Merged
jyameo
jyameo approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nshahan nshahan force-pushed the dwds-null-safety-cleanup branch from ba7afe8 to 72ed8cd Compare August 12, 2025 22:22
@nshahan nshahan merged commit 595f876 into main Aug 13, 2025
48 of 50 checks passed
@nshahan nshahan deleted the dwds-null-safety-cleanup branch August 13, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyameo jyameo jyameo approved these changes

@bkonyi bkonyi bkonyi approved these changes

Assignees
No one assigned
Labels
package:dwds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nshahan @bkonyi @jyameo